Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Sanity check PIN length for good measure #3879

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Desktop: Sanity check PIN length for good measure #3879

merged 3 commits into from
Sep 6, 2024

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Sep 5, 2024 •
edited by skotopes
Loading

What's new

  • Title
  • I forgot to PR this from few days ago, issues we had in CFW were unrelated to this but extra safety never hurts

Verification

  • PIN still works as intended
  • Setting PIN to unsupported length will leave desktop unlocked (previously, desktop would be impossible to unlock in this state)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit 4fd7652 into flipperdevices:dev Sep 6, 2024
10 of 11 checks passed
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@Willy-JL @skotopes @ofabel
Desktop: Sanity check PIN length for good measure (flipperdevices#3879)
0914761 
* Desktop: Sanity check PIN length for good measure
* Desktop: replace hardcoded values with macros in desktop_view_pin_input.c

Co-authored-by: あく <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @skotopes